Michael Pasternak has posted comments on this change. Change subject: restapi: Add "custom network configuration" to NIC (#838300) ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 2282: <xs:element name="custom_network_configuration" type="xs:boolean" minOccurs="0" maxOccurs="1"/> I wouldn't go with custom_network_configuration as: 1. it's not informative enough, i.e by seeing custom_network_configuration user cannot conclude that it's indicates if NIC in sync with cluster level network 2. custom_network_configuration is too long, we do not use more than two periods property names in api -- To view, visit http://gerrit.ovirt.org/6653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d6a678a0f1b793f4a218ec7eaf1ac2a2f815796 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
