Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Use common code for remote wsp pki ......................................................................
Patch Set 5: (6 comments) Nice, small comments inside. You are more than welcome to extend remote_engine with inline copy/paste interaction, which you had here and now drop, if you feel that's useful... http://gerrit.ovirt.org/#/c/33775/5/packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py File packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py: Line 94: @util.export Line 95: class Stages(object): Line 96: Line 97: CA_AVAILABLE = 'osetup.pki.ca.available' Line 98: PKI_MISC = 'osetup.pki.misc' Perhaps something a bit more specific? osetup.websocket-proxy.pki.misc or osetup.pki.websocket-proxy.misc ? Line 99: Line 100: CONFIG_WEBSOCKET_PROXY_CUSTOMIZATION = \ Line 101: 'setup.config.websocket-proxy.customization' Line 102: http://gerrit.ovirt.org/#/c/33775/5/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py: Line 140 Line 141 Line 142 Line 143 Line 144 both of these are done by remote_engine.add_to_transaction . What you saw in apache.py is for the symlinks there. Line 361 Line 362 Line 363 Line 364 Line 365 that's done by filetransaction above, no? Line 25: import time Line 26: Line 27: Line 28: import gettext Line 29: _ = lambda m: gettext.dgettext(message=m, domain='ovirt-engine-reports') ovirt-engine-reports ? :-) Line 30: Line 31: Line 32: from otopi import constants as otopicons Line 33: from otopi import filetransaction Line 95: owspcons.FileLocations.OVIRT_ENGINE_PKI_WEBSOCKET_PROXY_CERT Line 96: ) and os.path.exists( Line 97: owspcons.FileLocations.OVIRT_ENGINE_PKI_ENGINE_CERT Line 98: ) Line 99: ) Seems like you copied from reports' apache.py and not from jboss.py. Both are somewhat different from your previous wsp code. I did not carefully reviewed the below to see that it all makes sense, hope you did. Line 100: Line 101: if not engine_wsp_pki_found: Line 102: self._enrolldata = remote_engine.EnrollCert( Line 103: remote_engine=self.environment[ Line 159: self._engine_cert = engine_ca_cert Line 160: else: Line 161: self.logger.error( Line 162: _( Line 163: 'Failed to get engine from the engine. ' "to get engine certificate"? Line 164: 'Please check access to the engine and its ' Line 165: 'status.' Line 166: ) Line 167: ) -- To view, visit http://gerrit.ovirt.org/33775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id72711fb1577d5ee97454a36650456c2675206be Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
