Roy Golan has posted comments on this change. Change subject: core: Move cpu_over_commit from VdsDynamic to VdsStatistics ......................................................................
Patch Set 2: Code-Review+2 (2 comments) I'n not sure about the test failures. pls try the Rerun-Hooks: all comments to retrigger http://gerrit.ovirt.org/#/c/33794/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java: Line 338: this.cpuCoreStatistics = cpuCoreStatistics; Line 339: } Line 340: Line 341: public Date getcpu_over_commit_time_stamp() { Line 342: return this.cpu_over_commit_time_stamp; we had a chance to fit the name to the convention.. never mind for now Line 343: } Line 344: Line 345: public void setcpu_over_commit_time_stamp(Date value) { Line 346: this.cpu_over_commit_time_stamp = value; http://gerrit.ovirt.org/#/c/33794/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java: Line 52: entity.setHighlyAvailableIsConfigured(rs.getBoolean("ha_configured")); Line 53: entity.setHighlyAvailableIsActive(rs.getBoolean("ha_active")); Line 54: entity.setHighlyAvailableGlobalMaintenance(rs.getBoolean("ha_global_maintenance")); Line 55: entity.setHighlyAvailableLocalMaintenance(rs.getBoolean("ha_local_maintenance")); Line 56: entity.setcpu_over_commit_time_stamp(DbFacadeUtils.fromDate(rs looking at it now, we should use timestamp (i.e Integer) instead of Date (and discard the use of Date objects) just mentioning that as side-note this should always be our case when storing time data. if your up to changing that now it will be greatly appreciated, even though we will need to fit master as well. Line 57: .getTimestamp("cpu_over_commit_time_stamp"))); Line 58: return entity; Line 59: } Line 60: } -- To view, visit http://gerrit.ovirt.org/33794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I604132f9f05c8470ff09196db77eea2957899e2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
