Juan Hernandez has uploaded a new change for review.

Change subject: restapi: Fix use of "unregistered" parameter
......................................................................

restapi: Fix use of "unregistered" parameter

The "unregister" matrix parameter is used to include unregistered
objects (disks, templates and VMs) when listing or adding them. But the
paremeter is currently documented incorrectly, as it is missing from
some operations where it is used and included in other operations where
it isn't used. As a result the RSDL is incorrect and the Python and Java
SDKs don't implement it correctly. This patch fixes the documentation of
the parameter.

Change-Id: Ifccc9082d71cc6bb14ae9dfc7efd3c024a82639f
Bug-Url: https://bugzilla.redhat.com/1148715
Signed-off-by: Juan Hernandez <juan.hernan...@redhat.com>
---
M 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/33759/1

diff --git 
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
 
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
index afa8a19..af6b1f7 100644
--- 
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
+++ 
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
@@ -1657,6 +1657,7 @@
       signatures: []
     urlparams:
       max: {context: matrix, type: 'xs:int', value: 'max results', required: 
false}
+      unregistered: {context: matrix, type: 'xs:boolean', value: true|false, 
required: false}
     headers: {}
 - name: /storagedomains/{storagedomain:id}/templates/{template:id}|rel=get
   description: get the details of the specified template in the export or data 
domain
@@ -1716,6 +1717,7 @@
       signatures: []
     urlparams:
       max: {context: matrix, type: 'xs:int', value: 'max results', required: 
false}
+      unregistered: {context: matrix, type: 'xs:boolean', value: true|false, 
required: false}
     headers: {}
 - name: /storagedomains/{storagedomain:id}/vms/{vm:id}|rel=delete
   description: delete the specified virtual machine from the storage domain
@@ -4812,8 +4814,7 @@
     body:
       parameterType: null
       signatures: []
-    urlparams:
-      unregistered: {context: matrix, type: 'xs:boolean', value: true|false, 
required: false}
+    urlparams: {}
     headers: {}
 - name: /storagedomains/{storagedomain:id}/disks/{disk:id}|rel=delete
   description: delete the specified disk in the storage domain


-- 
To view, visit http://gerrit.ovirt.org/33759
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifccc9082d71cc6bb14ae9dfc7efd3c024a82639f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to