Martin Mucha has posted comments on this change. Change subject: webadmin: gui for adding macPool permissions. ......................................................................
Patch Set 14: (3 comments) few responses. http://gerrit.ovirt.org/#/c/32211/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3284: } Line 3285: else if (entity instanceof CpuProfile) Line 3286: { Line 3287: return ((CpuProfile) entity).getId(); Line 3288: } else if (entity instanceof MacPool) { > This change isn't required if you rebase this patch on top of the succeedin Done Line 3289: return ((MacPool) entity).getId(); Line 3290: } Line 3291: return Guid.Empty; Line 3292: } http://gerrit.ovirt.org/#/c/32211/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java: Line 276: Line 277: remove_shared_mac_pools("remove_shared_mac_pools", HelpTagType.WEBADMIN, "Configure > MAC Address Pools > Remove"), //$NON-NLS-1$ $NON-NLS-2$ Line 278: Line 279: //TODO MM: is this correct comment? Line 280: remove_shared_mac_pool_permissions("remove_shared_mac_pool_permissions", HelpTagType.WEBADMIN, "Configure > MAC Address Pools > Remove"), //$NON-NLS-1$ $NON-NLS-2$ > Now that you're using PermissionListModel, this can be removed (that's okay Done Line 281: Line 282: new_domain("new_domain", HelpTagType.WEBADMIN, "Storage Tab > New Domain"), //$NON-NLS-1$ //$NON-NLS-2$ Line 283: Line 284: new_external_subnet("new_external_subnet", HelpTagType.WEBADMIN, "Networks main tab -> External Subnet sub tab -> New"), //$NON-NLS-1$ //$NON-NLS-2$ http://gerrit.ovirt.org/#/c/32211/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java: Line 122: setConfirmWindow(null); Line 123: } Line 124: Line 125: private void onRemove() { Line 126: setConfirmWindow(null); > Please revert this change - it's customary in many Model classes to have ca I can, of course, but are you aware, that this is utterly wrong? Metaphor: when women give birth to a baby it does not include pregnancy interruption although baby comes out, right? Submit *does not* include/aggregate cancel. Being equally wrong as others does not turn your actions into correct ones. —— Still want to do wrong thing? Line 127: ArrayList<VdcActionParametersBase> params = new ArrayList<VdcActionParametersBase>(); Line 128: for (MacPool macPool : (Iterable<MacPool>) getSelectedItems()) { Line 129: params.add(new RemoveMacPoolByIdParameters(macPool.getId())); Line 130: } -- To view, visit http://gerrit.ovirt.org/32211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb6b442e7eebce367b9008f4b9c1df9ade84745f Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
