Eli Mesika has posted comments on this change.

Change subject: core: medium Instance Type mismatch feature page
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/33459/2/packaging/dbscripts/upgrade/03_06_0410_medium_instance_type_has_two_cpus.sql
File 
packaging/dbscripts/upgrade/03_06_0410_medium_instance_type_has_two_cpus.sql:

Line 1: select vm_guid into medium_instance_type_id from vm_static where 
entity_type = 'INSTANCE_TYPE' and vm_name = 'Medium' and description = 'Medium 
instance type' and mem_size_mb = 4096 and num_of_sockets = 1 and cpu_per_socket 
= 1;
Line 2: 
Line 3: -- update the instance type itself
Line 4: update vm_static set num_of_sockets = 2 where vm_guid = (select * from 
medium_instance_type_id);
a in operation is more straight forward here ....


where vm_guid in (select .....
Line 5: 
Line 6: -- update the VMs based on that instance type
Line 7: update vm_static set num_of_sockets = 2 where instance_type_id = 
(select * from medium_instance_type_id);
Line 8: 


Line 3: -- update the instance type itself
Line 4: update vm_static set num_of_sockets = 2 where vm_guid = (select * from 
medium_instance_type_id);
Line 5: 
Line 6: -- update the VMs based on that instance type
Line 7: update vm_static set num_of_sockets = 2 where instance_type_id = 
(select * from medium_instance_type_id);
same
Line 8: 


-- 
To view, visit http://gerrit.ovirt.org/33459
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03407f86c272578cec671f49e89d2ffbeb93ae4d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to