Livnat Peer has posted comments on this change. Change subject: engine: Add create from network to tests ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java Line 611: I am not sure i understand the need for two methods. If one is with network and the other is without then why do we need networkName in the signature of createNic -- To view, visit http://gerrit.ovirt.org/6649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I511d6cce0d906f1482d9c975e7037341d9cb8d69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
