Alon Bar-Lev has posted comments on this change. Change subject: tools: Replaces log4j with JUL as backend for manage-domains ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/32853/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java: Line 28: Line 29: public static void setupCustomLogging(String configFile, String logFile, String logLevel) { Line 30: if (configFile != null) { Line 31: try (InputStream is = new FileInputStream(configFile)) { Line 32: JavaLoggingUtils.setupLogging(is); > So we can have /etc/ovirt-engine/engine-manage-domains/logging.properties w /usr/share/ovirt-engine/conf/tools-logging.properties as it is not for user to modify. so by default we feed -D java.util.logging=/usr/share/ovirt-engine/conf/tools-logging.properties, while user can play with log level using parameter. if user wants to replace the entire logging file he can do this via environment to make it easier for us, example: OVIRT_LOGGING_PROPERTIES=/tmp/my engine-manage-domains Line 33: } catch (IOException ex) { Line 34: throw new IllegalArgumentException( Line 35: String.format("Error loading loggging configuration from '%s': %s", configFile, ex.getMessage()), Line 36: ex); http://gerrit.ovirt.org/#/c/32853/3/backend/manager/modules/builtin-extensions/src/main/resources/engine-manage-domains/logging.properties File backend/manager/modules/builtin-extensions/src/main/resources/engine-manage-domains/logging.properties: Line 6: # To change logging properties for engine-manage-domains user command line Line 7: # options --log-file, --log-level and --log-config Line 8: Line 9: # Set root level to ALL, so it can be changed per handler using command line parameter --log-level Line 10: .level=ALL > I know what's wrong. I set log level only to handler, but not to the "org.o this is expected, so the .level can be set to WARNING and ovirt.org.level set to INFO per default. Line 11: Line 12: # Default format of log line is: DATE TIME LEVEL [SOURCE] Message Stacktrace -- To view, visit http://gerrit.ovirt.org/32853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16afc336c26615978392f7d4ff911bf646c42df6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
