Maor Lipchuk has posted comments on this change.

Change subject: core: Adding VdcObjectType.Storage to JobMessageProperties
......................................................................


Patch Set 1: Looks good to me, approved

You can remove the storage pool action type from getJobMessageProperties since 
it is already added to the jobProperties when we check permission for Data 
Center in getPermissionCheckSubjects

--
To view, visit http://gerrit.ovirt.org/6694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I534d2b6f57e237d01cc32d3a725b1a0eaefae64e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to