anmolbabu has posted comments on this change.

Change subject: engine : Bll Command for Create Geo Rep session
......................................................................


Patch Set 16:

(2 comments)

http://gerrit.ovirt.org/#/c/29834/16/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java:

Line 380:     GLUSTER_VOLUME_DETAILS_REFRESH_FAILED(4094, 
AuditLogSeverity.ERROR),
Line 381:     USER_FORCE_SELECTED_SPM_STOP_FAILED(4096, AuditLogSeverity.ERROR),
Line 382:     GLUSTER_VOLUME_PASSWORD_LESS_SSH_FAILED(4097, 
AuditLogSeverity.ERROR),
Line 383:     GLUSTER_VOLUME_GEO_REP_CREATE_FAILED(4098, 
AuditLogSeverity.ERROR),
Line 384:     GLUSTER_VOLUME_GEO_REP_CREATE(4099),
> I feel order could better be
Done
Line 385: 
Line 386:     USER_FORCE_SELECTED_SPM(159),
Line 387:     USER_VDS_RESTART(41),
Line 388:     USER_FAILED_VDS_RESTART(107, AuditLogSeverity.ERROR),


http://gerrit.ovirt.org/#/c/29834/16/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java:

Line 300:     StopRemoveGlusterVolumeBricks(1423, 
ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE),
Line 301:     CommitRemoveGlusterVolumeBricks(1424, 
ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE),
Line 302:     RefreshGlusterVolumeDetails(1425, 
ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE),
Line 303:     GlusterVolumeGeoRepStart(1426, 
ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE),
Line 304:     GlusterVolumeGeoRepSessionCreate(1426, 
ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE),
> Same code 1426??
Done
Line 305: 
Line 306:     // Scheduling Policy
Line 307:     AddClusterPolicy(1450, 
ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE),
Line 308:     EditClusterPolicy(1451, 
ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE),


-- 
To view, visit http://gerrit.ovirt.org/29834
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccc92235deea42d7818336b2402476193cbe789c
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to