Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/33458/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 274: " }\n" + Line 275: " ]\n" + Line 276: " }\n" + Line 277: "}"; Line 278: runHttpModificatioMethod(HttpMethodType.PUT, Paths.get(DISCOVERED_HOSTS_ENTRY_POINT,discoverName).toString(), entityBody); > not sure i understand what you mean here. POINT,dis->POINT, dis Line 279: } Line 280: Line 281: @Override Line 282: public void testConnection() { http://gerrit.ovirt.org/#/c/33458/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 69 Line 70 Line 71 Line 72 Line 73 > see usages - by git grep. we do not need this if we use the new HttpURLConnection implementation, where do we do this twice? why do we need to use it? not sure I understand. -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
