Alexander Wels has posted comments on this change. Change subject: core : Display custom error page if reports is not installed ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33218/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java: Line 37: super.init(config); Line 38: Line 39: // we use %{x} convention to avoid conflict with jboss properties Line 40: url = EngineLocalConfig.getInstance().expandString(config.getInitParameter(URL).replaceAll("%\\{", "\\${")); Line 41: url404 = EngineLocalConfig.getInstance().expandString(config.getInitParameter(URL404).replaceAll("%\\{", "\\${")); You should add a fallback in case the web.xml doesn't specify a url404 in the configuration. To prevent similar issue to the proxy interface when the reports are not installed. I would either simply point to the real 404.html, or some generic not installed message. Line 42: } Line 43: Line 44: @Override Line 45: protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { -- To view, visit http://gerrit.ovirt.org/33218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaed902328695e2d448ac49c414ddfbde8d3fd25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
