Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 7: (5 comments) http://gerrit.ovirt.org/#/c/33458/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 357: if (isSecured()) { Line 358: builder.setTrustStoreType("JKS") Line 359: .setTrustStorePassword(EngineLocalConfig.getInstance().getPKITrustStorePassword()) Line 360: .setTrustManagerAlgorithm(TrustManagerFactory.getDefaultAlgorithm()) Line 361: .setTrustStore(EngineLocalConfig.getInstance().getVarDir() + "/" + "external_truststore"); please use file in order to construct paths. Line 362: } Line 363: result = builder.create(); Line 364: handleCredentials(result); Line 365: } catch (Exception ex) { Line 373: connection.setRequestProperty("Auhtorization", Line 374: new StringBuilder("Basic ").append(hostProvider.getUsername()) Line 375: .append(":") Line 376: .append(hostProvider.getPassword()) Line 377: .toString()); don't you need base64 it? Line 378: } Line 379: } Line 380: http://gerrit.ovirt.org/#/c/33458/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 69 Line 70 Line 71 Line 72 Line 73 I do not think we need that now. Line 77 Line 78 Line 79 Line 80 Line 81 this as well... we always provide trust store, no? http://gerrit.ovirt.org/#/c/33458/7/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java: Line 182 Line 183 Line 184 Line 185 Line 186 can we remove it entirely? -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
