Martin Mucha has posted comments on this change. Change subject: webadmin: refactor—overgrown constructor ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/32210/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/SharedMacPoolView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/SharedMacPoolView.java: Line 33: final ApplicationConstants constants, Line 34: final ApplicationResources resources) { Line 35: Line 36: SplitLayoutPanel rootPanel = createRootPanel(); Line 37: macPoolTable = createMacPoolTable(sharedMacPoolModelProvider, eventBus, clientStorage, headerlessResources, > I'll be okay with members - thought about it originally and it seemed like Done Line 38: tableResources, constants, resources); Line 39: Line 40: rootPanel.add(macPoolTable); Line 41: initWidget(rootPanel); Line 40: rootPanel.add(macPoolTable); Line 41: initWidget(rootPanel); Line 42: } Line 43: Line 44: protected SplitLayoutPanel createRootPanel() { > Any reason why this would be protected and not private? Done Line 45: SplitLayoutPanel rootPanel = new SplitLayoutPanel(); Line 46: rootPanel.setHeight("495px"); //$NON-NLS-1$ Line 47: rootPanel.setWidth("100%"); //$NON-NLS-1$ Line 48: return rootPanel; -- To view, visit http://gerrit.ovirt.org/32210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05d1ec1064eb3ec4ce17f88a2d532cb76aa4f39d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
