Moti Asayag has posted comments on this change. Change subject: uutils: Extract connectionBuilder class ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/33479/5/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/http/ConnectionBuilder.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/http/ConnectionBuilder.java: Line 90: } Line 91: Line 92: Line 93: public HttpURLConnection create() throws IOException, GeneralSecurityException { Line 94: connection = new URL(url).openConnection(); connection should be a local variable, and create() produces a new instance without keeping a reference to it. Line 95: connection.setAllowUserInteraction(false); Line 96: connection.setUseCaches(false); Line 97: if (readTimeout != null) { Line 98: connection.setReadTimeout(readTimeout); -- To view, visit http://gerrit.ovirt.org/33479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ea4e7301b3a018b0438fff25cefad80ebd7256 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
