Maor Lipchuk has posted comments on this change. Change subject: webadmin: Add checkbox for format when remove Storage domain ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/33287/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 784: StorageDomain storage = (StorageDomain) storageListModel.getSelectedItem(); Line 785: ArrayList<VDS> hosts = (ArrayList<VDS>) returnValue; Line 786: removeStorageModel.getHostList().setItems(hosts); Line 787: removeStorageModel.getHostList().setSelectedItem(Linq.firstOrDefault(hosts)); Line 788: removeStorageModel.getFormat().setEntity(!storage.getStorageDomainType().isIsoOrImportExportDomain()); > Does this mean that we set the checkbox "format" bu default for data domain yes, done Line 789: Line 790: if (hosts.isEmpty()) { Line 791: UICommand tempVar = createCancelCommand("Cancel"); //$NON-NLS-1$ Line 792: tempVar.setIsDefault(true); -- To view, visit http://gerrit.ovirt.org/33287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia844883ebca19be9c4f6a26f7c34b3423bf0f2d3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
