Moti Asayag has posted comments on this change. Change subject: core:fixing step numbering for steps and sub-steps ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33426/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java: Line 289: Line 290: try { Line 291: Job job = context.getJob(); Line 292: if (context.getExecutionMethod() == ExecutionMethod.AsJob && job != null) { Line 293: JobRepositoryFactory.getJobRepository().loadJobSteps(job); > I like the initialized idea. Eli and I re-examined the code and the usages and it seems that the only places where such behavior might happen is in AddStepCommand. So the better approach would be populating the context with steps for Job or for the parent step from that command. Line 294: step = job.addStep(stepName, description); Line 295: try { Line 296: step.setExternal(isExternal); Line 297: JobRepositoryFactory.getJobRepository().saveStep(step); -- To view, visit http://gerrit.ovirt.org/33426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic72e9ab64160116f4fbac3f3b2cdea63db7b9c75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
