Livnat Peer has posted comments on this change. Change subject: core: Add network details to host's network device ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java Line 404: I don't think the name of this class is expressive of it's content. I think this class holds information about connection between the logical and physical network. Any information that is purely related to the network should go into the network class. I am not sure I would create a separate class for it at all, what future properties do you see go into this class? Another point for consideration - If we had good design for the interface hierarchy and we had a separate class for each device where would you locate this property? -- To view, visit http://gerrit.ovirt.org/6646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d5bd0986eccac5de2c146c9e47cd424e9ead3bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
