Lior Vernia has posted comments on this change. Change subject: frontend: refactoring: Generify Events and Listeners ......................................................................
Patch Set 8: (8 comments) Sorry to spoil the party, I'm still not happy about what this patch achieves... :) I checked a couple of classes and every class I checked still had a non-parametrized Event argument in the implementation of eventRaised(); I suspect this is the case everywhere. So in my opinion, and as commented before, this patch doesn't eliminate the IDE warnings it set out to eliminate. http://gerrit.ovirt.org/#/c/32837/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java: Line 71: items = new LinkedList<Pair<T, V>>(); Line 72: itemsChangedListener = new IEventListener<EventArgs>() { Line 73: Line 74: @Override Line 75: public void eventRaised(Event ev, Object sender, EventArgs args) { Event here requires parametrization. Line 76: init(model); Line 77: } Line 78: }; Line 79: propertyChangedListener = new IEventListener<PropertyChangedEventArgs>() { Line 78: }; Line 79: propertyChangedListener = new IEventListener<PropertyChangedEventArgs>() { Line 80: Line 81: @Override Line 82: public void eventRaised(Event ev, Object sender, PropertyChangedEventArgs args) { Event here requires parametrization. Line 83: if ("IsChangable".equals(args.propertyName)) { //$NON-NLS-1$ Line 84: enabled = model.getIsChangable(); Line 85: updateEnabled(); Line 86: } http://gerrit.ovirt.org/#/c/32837/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java: Line 86: public void edit(final KeyValueLineModel object) { Line 87: updateKeyTitle(object); Line 88: object.getKeys().getSelectedItemChangedEvent().addListener(new IEventListener<EventArgs>() { Line 89: @Override Line 90: public void eventRaised(Event ev, Object sender, EventArgs args) { Event here requires parametrization. Line 91: ValueChangeEvent.fire(KeyValueLineWidget.this, object); Line 92: updateKeyTitle(object); Line 93: } Line 94: }); http://gerrit.ovirt.org/#/c/32837/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java: Line 77: syncSelectedItemWithNetworkInterface(model); Line 78: model.getSelectedItemChangedEvent().addListener(new IEventListener<EventArgs>() { Line 79: Line 80: @Override Line 81: public void eventRaised(Event ev, Object sender, EventArgs args) { Event here requires parametrization. Line 82: syncSelectedItemWithNetworkInterface(model); Line 83: ValueChangeEvent.fire(ProfileInstanceTypeEditor.this, model); Line 84: } Line 85: }); http://gerrit.ovirt.org/#/c/32837/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java: Line 182: hideMacWhenNotEnabled(iface); Line 183: iface.getMAC().getPropertyChangedEvent().addListener(new IEventListener<PropertyChangedEventArgs>() { Line 184: Line 185: @Override Line 186: public void eventRaised(Event ev, Object sender, PropertyChangedEventArgs args) { Event here requires parametrization. Line 187: if ("IsAvailable".equals(args.propertyName)) { //$NON-NLS-1$ Line 188: hideMacWhenNotEnabled(iface); Line 189: } Line 190: } http://gerrit.ovirt.org/#/c/32837/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java: Line 188: Line 189: // Add selection listener Line 190: getModel().getSelectedItemChangedEvent().addListener(new IEventListener<EventArgs>() { Line 191: @Override Line 192: public void eventRaised(Event ev, Object sender, EventArgs args) { Event here requires parametrization. Line 193: updateInfoPanel(); Line 194: } Line 195: }); Line 196: Line 195: }); Line 196: Line 197: getModel().getItemsChangedEvent().addListener(new IEventListener<EventArgs>() { Line 198: @Override Line 199: public void eventRaised(Event ev, Object sender, EventArgs args) { Event here requires parametrization. Line 200: updateInfoPanel(); Line 201: } Line 202: }); Line 203: } http://gerrit.ovirt.org/#/c/32837/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java: Line 42: Line 43: getItemsChangedEvent().addListener(new IEventListener<EventArgs>() { Line 44: Line 45: @Override Line 46: public void eventRaised(Event ev, Object sender, EventArgs args) { Event here requires parametrization. Line 47: for (ClusterNetworkModel model : getItems()) { Line 48: if (model.isManagement()) { Line 49: managementNetwork = model; Line 50: } -- To view, visit http://gerrit.ovirt.org/32837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icddf5780c00c985966e6ae956a401c3ede6a68e7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
