Shubhendu Tripathi has posted comments on this change. Change subject: engine : Bll command to start geo-rep session ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/32537/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 378: REMOVE_GLUSTER_VOLUME_BRICKS_NOT_FOUND_FROM_CLI(4092, AuditLogSeverity.WARNING), Line 379: GLUSTER_VOLUME_DETAILS_REFRESH(4093), Line 380: GLUSTER_VOLUME_DETAILS_REFRESH_FAILED(4094, AuditLogSeverity.ERROR), Line 381: GLUSTER_VOLUME_GEO_REP_START_FAILED_EXCEPTION(4595, AuditLogSeverity.ERROR), Line 382: GLUSTER_VOLUME_GEO_REP_START(4596), Mostly we keep success first and error second. Just a suggestion to reverse the order. Line 383: USER_FORCE_SELECTED_SPM_STOP_FAILED(4096, AuditLogSeverity.ERROR), Line 384: USER_FORCE_SELECTED_SPM(159), Line 385: USER_VDS_RESTART(41), Line 386: USER_FAILED_VDS_RESTART(107, AuditLogSeverity.ERROR), http://gerrit.ovirt.org/#/c/32537/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 299: StartRemoveGlusterVolumeBricks(1422, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 300: StopRemoveGlusterVolumeBricks(1423, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 301: CommitRemoveGlusterVolumeBricks(1424, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 302: RefreshGlusterVolumeDetails(1425, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 303: GlusterVolumeGeoRepStart(1428, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Why 1428 after 1425 ? If some other patch using those codes, order the patches properly. Line 304: Line 305: // Scheduling Policy Line 306: AddClusterPolicy(1450, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 307: EditClusterPolicy(1451, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), http://gerrit.ovirt.org/#/c/32537/4/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 794: GLUSTER_SERVICE_RESTART_FAILED=Could not re-start ${servicetype} service on host ${VdsName} on cluster ${VdsGroupName}. Line 795: GLUSTER_VOLUME_BRICK_ADDED=Brick [${brickpath}] on host [${servername}] added to volume [${glusterVolumeName}] Line 796: GLUSTER_BRICK_STATUS_CHANGED=Detected change in status of brick ${brickpath} of volume ${glusterVolumeName} from ${oldValue} to ${newValue}. Line 797: GEOREP_SESSION_STARTED=Geo-replication session on volume ${glusterVolumeName} has been started. Line 798: GEOREP_SESSION_STARTED_FAILED=Failed to start geo-replication session on volume ${glusterVolumeName} %s/GEOREP_SESSION_STARTED_FAILED/GEOREP_SESSION_START_FAILED/g Line 799: VDS_UNTRUSTED=Host ${VdsName} was set to non-operational. Host is not trusted by the attestation service. Line 800: USER_ADDED_NETWORK_QOS=Network QoS ${NetworkQoSName} was added. (User: ${UserName}) Line 801: USER_FAILED_TO_ADD_NETWORK_QOS=Failed to add Network QoS ${NetworkQoSName}. (User: ${UserName}) Line 802: USER_REMOVED_NETWORK_QOS=Network QoS ${NetworkQoSName} was removed. (User: ${UserName}) -- To view, visit http://gerrit.ovirt.org/32537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib74c515d23218bb2e30403e0e0042c84b74dc2bb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
