Oved Ourfali has posted comments on this change. Change subject: core: retry fencing operation in case of failure ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33486/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java: Line 538: ThreadUtils.sleep(getDelayInSeconds() * 1000); Line 539: i++; Line 540: j++; Line 541: continue; Line 542: } I'd put the rest of the code in else. putting "continue" makes it harder to understand the flow here. Line 543: // No need to retry , agent definitions are corrupted Line 544: log.warnFormat("Host {0} {1} PM Agent definitions are corrupted, Waiting for Host to {2} aborted.", vdsName, order.name(), actionType.name()); Line 545: break; Line 546: } -- To view, visit http://gerrit.ovirt.org/33486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5dadd5cb07f2c61dfdf6d75e9fccca790ba483 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
