Greg Padgett has posted comments on this change. Change subject: core: Enable Live Merge in Snapshots Overview ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/32338/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java: Line 9: import org.ovirt.engine.core.compat.Guid; Line 10: import org.ovirt.engine.core.utils.log.Log; Line 11: import org.ovirt.engine.core.utils.log.LogFactory; Line 12: Line 13: public class RemoveDiskSnapshotsCommandCallback extends CommandCallBack { > Yikes :) Yeah, I get it now. It should have been much simpler if RemoveSnap I have to agree, the previous design seems better after comparing the two. Not mixing the two frameworks makes the code much simpler and probably less prone to accidental breakage. (As for it being better if RemoveSnapshotSingleDiskLive was a regular command: you can say that again :) Just wasn't possible to make it happen...) Line 14: private static final Log log = LogFactory.getLog(RemoveDiskSnapshotsCommandCallback.class); Line 15: Line 16: @Override Line 17: public void doPolling(Guid cmdId, List<Guid> childCmdIds) { -- To view, visit http://gerrit.ovirt.org/32338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30d152a70ebdeacf0410d7ad15a49e44fb564a18 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
