Shahar Havivi has posted comments on this change. Change subject: engine: cannot set payload and cloud-init on same devices. ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/33318/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 217: null, Line 218: null, Line 219: null); Line 220: Map<String, Object> struct = new HashMap<String, Object>(); Line 221: addFloppyDetails(vmDevice, struct); This is an ancient bug... it causes the floppy to pose as 'hdc' in libvirt instead of 'fda' Line 222: addDevice(struct, vmDevice, ""); Line 223: } Line 224: // check first if Floppy was given as a parameter Line 225: else if (vm.isRunOnce() && !StringUtils.isEmpty(vm.getFloppyPath())) { -- To view, visit http://gerrit.ovirt.org/33318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5b701f058a2d87b2836d337f822d2f012d10bbe Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
