Allon Mureinik has posted comments on this change. Change subject: restapi: Do not attempt to extend a block domain if LUNs data not supplied ......................................................................
Patch Set 1: Code-Review+1 (1 comment) code looks OK, see style nitpicking inline. http://gerrit.ovirt.org/#/c/33498/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java: Line 135: * @param incoming Line 136: */ Line 137: private void extendStorageDomain(StorageDomain incoming, StorageDomain storageDomain, StorageType storageType) { Line 138: if (incoming.getStorage() == null) { Line 139: // LUNs info was not supplied in the request so no need to check whether to extend I'd indent this to match the "return;" indentation. Line 140: return; Line 141: } Line 142: List<LogicalUnit> existingLuns = storageDomain.getStorage().getVolumeGroup().getLogicalUnits(); Line 143: List<LogicalUnit> incomingLuns = getIncomingLuns(incoming.getStorage()); -- To view, visit http://gerrit.ovirt.org/33498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf4b28c2dbc289b88107f1e7fdc19127fb536326 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
