Frank Kobzik has uploaded a new change for review. Change subject: frontend: Fix SPICE-ActiveX upgrade issues ......................................................................
frontend: Fix SPICE-ActiveX upgrade issues This patch basically reverts previous IE 11 workaround: Syntax error (missing '+' to concatenate strings) in SpicePluginImpl caused silent fail of activex plugin in IE. This patch addresses this. This patch also removes IE11 workaround from SpicePluginImpl (i.e. dummy <PARAM NAME="SecurePort" VALUE="0">). Current SPICE ActiveX plugin already works on IE 11 without this workaround (moreover - it crashes with it!). Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Bug-Url: https://bugzilla.redhat.com/1081533 Signed-off-by: Frantisek Kobzik <fkob...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/33487/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java index b0dc38d..5894b11 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java @@ -86,9 +86,7 @@ public native String loadActiveX(String id, String codebase, String classId) /*-{ var container = $wnd.document.createElement("div"); container.innerHTML = '<object id="' + id + '" codebase="' + codebase + '" classid="CLSID:' + classId - + '" width="0" height="0">' + - '<PARAM NAME="SecurePort" VALUE="0">' - '</object>'; // <PARAM ...> element is workaround to make spice activex addon working with ie 11 + + '" width="0" height="0"></object>'; container.style.width = "0px"; container.style.height = "0px"; container.style.position = "absolute"; -- To view, visit http://gerrit.ovirt.org/33487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
