Alexander Wels has posted comments on this change. Change subject: core, webadmin : Fix issues with reports integration ......................................................................
Patch Set 2: So if I understand this correctly then the following is true: 1. /ovirt-engine/reports-redirect points to ENGINE_REPORTS_DASHBOARD_URL whatever that is. 2. /ovirt-engine/right-click-reports-redirect points to ENGINE_REPORTS_DASHBOARD_URL/flow.html?_flowId=viewReportFlow To me it makes no sense to introduce a new URL just to pass some different parameters to an existing URL. I understand you don't want to hard code the parameters in the webadmin application, but it is possible to pass values that are read from the configuration to the web admin at runtime. I would consider that a much better option than introducing new redirect URLs each time we need some different parameters. -- To view, visit http://gerrit.ovirt.org/33289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5e91aa80dcd4e4d4f175d0193e92d19e65281e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
