Tomas Jelinek has posted comments on this change. Change subject: core,webadmin: show list of changed fields when updating running vm ......................................................................
Patch Set 4: Code-Review+1 (1 comment) only a small comment - you can decide if that fits into this patch (since targeted to 3.5) or a followup. Otherwise the FE looks ok to me. http://gerrit.ovirt.org/#/c/33046/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 2018: getcurrentVm().setCreatedByUserId(selectedItem.getCreatedByUserId()); Line 2019: getcurrentVm().setUseLatestVersion(constants.latestTemplateVersionName().equals(model.getTemplate().getSelectedItem().getTemplateVersionName())); Line 2020: Line 2021: if (selectedItem.isRunningOrPaused()) { Line 2022: AsyncDataProvider.getInstance().isNextRunConfigurationChanged(editedVm, getcurrentVm(), getUpdateVmParameters(false), new AsyncQuery(this, since the isNextRunConfigurationChanged does not return Boolean anymore, I would rename it to getChangedFieldsForNextRun() or similar. Line 2023: new INewAsyncCallback() { Line 2024: @Override Line 2025: public void onSuccess(Object thisModel, Object returnValue) { Line 2026: List<String> changedFields = ((VdcQueryReturnValue)returnValue).<List<String>> getReturnValue(); -- To view, visit http://gerrit.ovirt.org/33046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf13a19d1b193037226cb49bc6c1e8cefc0553b8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
