Sandro Bonazzola has posted comments on this change. Change subject: build: ovirt-engine-3.5.0 ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33084/4/build-tools-root/jboss-modules-maven-plugin/pom.xml File build-tools-root/jboss-modules-maven-plugin/pom.xml: Line 19: Maven Plugin used to generate and attach an artifact containing Line 20: JBoss modules Line 21: </description> Line 22: Line 23: <artifactId>jboss-modules-maven-plugin</artifactId> > No, you can't leave it without the -SNAPSHOT. Only one commit in the git re So if it doesn't hurt, better to leave it as is avoiding extra complexity Line 24: <version>1.1-SNAPSHOT</version> Line 25: <packaging>maven-plugin</packaging> Line 26: Line 27: <dependencies> -- To view, visit http://gerrit.ovirt.org/33084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6ce1d7d5d1afb59e64bc81bd3128c8b2ccb555d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
