Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Adding a dialog to let the user review iptables changes ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33085/1/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 380: def UPDATE_FIREWALL(self): Line 381: return 'OVESETUP_CONFIG/updateFirewall' Line 382: Line 383: FIREWALL_MANAGERS = 'OVESETUP_CONFIG/firewallManagers' Line 384: SKIP_FIREWALL_REVIEW = 'OVESETUP_CONFIG/skipFirewallReview' > I perfectly agree on the general schema. I do not agree this is different from any other question. If a user changed iptables rules, it's not S0 anymore. We have many questions that are conditional - e.g. if you run on a machine with 16GB ram you won't be asked about memory, but you will on a 1GB machine - so an answer file from the first will not be enough for unattended setup. What's so special about iptables? Line 385: VALID_FIREWALL_MANAGERS = 'OVESETUP_CONFIG/validFirewallManagers' Line 386: FQDN_REVERSE_VALIDATION = 'OVESETUP_CONFIG/fqdnReverseValidation' Line 387: FQDN_NON_LOOPBACK_VALIDATION = 'OVESETUP_CONFIG/fqdnNonLoopback' Line 388: -- To view, visit http://gerrit.ovirt.org/33085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63e0eeb26d925c8c79b9c8e55da64c57ce94a3f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
