anmolbabu has posted comments on this change.

Change subject: engine : VDS Command for geo-replication session create
......................................................................


Patch Set 14:

(3 comments)

http://gerrit.ovirt.org/#/c/29833/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java:

Line 208:     public BackendInternal getBackendInstance() {
Line 209:         return Backend.getInstance();
Line 210:     }
Line 211: 
Line 212:     public String getHostSSHFingerPrint(String hostName) {
> Is this used in this patch? If not, can you remove this file from the patch
Done.Its being used in the bll patch.I'll move it to there
Line 213:         try (EngineSSHClient client = new EngineSSHClient()){
Line 214:             connect(client, hostName);
Line 215:             return client.getHostFingerprint();
Line 216:         } catch (IOException e) {


http://gerrit.ovirt.org/#/c/29833/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepVDSParamaters.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepVDSParamaters.java:

Line 1: package org.ovirt.engine.core.common.vdscommands.gluster;
Line 2: 
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4: 
Line 5: public class GlusterVolumeGeoRepVDSParamaters extends 
GlusterVolumeVDSParameters {
> Can you reuse GlusterVolumeGeoRepSessionVDSParameters.java or extend from i
Done
Line 6:     //Master Volume id is volumeId of base class
Line 7: 
Line 8:     private String slaveNodeIp;
Line 9: 


http://gerrit.ovirt.org/#/c/29833/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java:

Line 275:     StatusOnlyReturnForXmlRpc glusterVolumeProfileStart(String 
volumeName);
Line 276: 
Line 277:     StatusOnlyReturnForXmlRpc glusterVolumeProfileStop(String 
volumeName);
Line 278: 
Line 279:     StatusOnlyReturnForXmlRpc glusterVolumeCreateGeoRepSession(Guid 
masterServerId, String masterVolumeName, String slaveServerIp, String 
slaveVolumeName);
> Why is masterServerId required? This will be executed on the node that cont
Done
Line 280: 
Line 281:     StatusOnlyReturnForXmlRpc glusterValidateSshConnection(String 
hostName, String fingerPrint, String userName);
Line 282: 
Line 283:     StatusOnlyReturnForXmlRpc glusterSetupSshConnection(String 
hostname, String fingerprint, String username, String password);


-- 
To view, visit http://gerrit.ovirt.org/29833
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8164990c5c377481f1b1244ae548f7eca3066b6
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to