Omer Frenkel has uploaded a new change for review. Change subject: core: don't use hotplug when updating instance type ......................................................................
core: don't use hotplug when updating instance type when updating vms connected to an instance type, if using hotplug (for cpu) and it fails, the change is lost. so always use "apply later" so the changes would anyway apply when the vm is down. Change-Id: I8f5b494a91ef3328fb2631da922c8a3cd582f67b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372 Signed-off-by: Omer Frenkel <ofren...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/33425/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java index 4b43583..a91989d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java @@ -221,7 +221,9 @@ // get vms from db List<VM> vmsToUpdate = getVmDAO().getVmsListByInstanceType(getVmTemplateId()); for (VM vm : vmsToUpdate) { - runInternalAction(VdcActionType.UpdateVm, new VmManagementParametersBase(vm)); + VmManagementParametersBase params = new VmManagementParametersBase(vm); + params.setApplyChangesLater(true); + runInternalAction(VdcActionType.UpdateVm, params); } } -- To view, visit http://gerrit.ovirt.org/33425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8f5b494a91ef3328fb2631da922c8a3cd582f67b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
