Moti Asayag has posted comments on this change. Change subject: core: AuditLogType.UNASSIGNED should not be logged ......................................................................
Patch Set 1: I agree with your concern regarding the hidden semantic granted to UNASSINGED audit-log-type without a message. The suggested solution is a good start to make it more coherent. However, that change could be separated from the rest of the code refactoring suggested by this patch iiuc. -- To view, visit http://gerrit.ovirt.org/33359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97bf90264d1a1b3d8ea571daa9346d1f6b6d18d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
