Greg Sheremeta has uploaded a new change for review.

Change subject: webadmin: tweak info icons in cluster popup
......................................................................

webadmin: tweak info icons in cluster popup

Tweak info icon location and spacing in cluster popup.

Change-Id: I61c4120ac6869b27d9faa2a3a0481d768911a5bb
Bug-Url: https://bugzilla.redhat.com/1123319
Bug-Url: https://bugzilla.redhat.com/1096845
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
2 files changed, 5 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/33371/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
index 8adb0e4..a95c3f9 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
@@ -77,7 +77,7 @@
         }
         .panelInfo {
             display: inline-block;
-            margin-left: 20px;
+            margin-left: 5px;
         }
         .nestedSubsequentPanel {
             padding-top: 24px;
@@ -200,7 +200,7 @@
                             <g:FlowPanel 
addStyleNames="{style.optimizationTabPanel}">
                                 <g:FlowPanel 
addStyleNames="{style.radioButtonsTabContent}">
                                     <g:Label 
ui:field="memoryOptimizationPanelTitle" addStyleNames="{style.panelTitle}" />
-                                    <d:InfoIcon 
ui:field="memoryOptimizationInfo" addStyleNames="{style.panelInfo} 
cpv_panelInfo_pfly_fix" />
+                                    <d:InfoIcon 
ui:field="memoryOptimizationInfo" addStyleNames="{style.panelInfo}" />
                                     <ge:EntityModelRadioButtonEditor 
ui:field="optimizationNoneEditor" 
addStyleNames="{style.radioButtonPositioning}"/>
                                     <ge:EntityModelRadioButtonEditor 
ui:field="optimizationForServerEditor" 
addStyleNames="{style.radioButtonPositioning}"/>
                                     <ge:EntityModelRadioButtonEditor 
ui:field="optimizationForDesktopEditor" 
addStyleNames="{style.radioButtonPositioning}"/>
@@ -208,7 +208,7 @@
                                 </g:FlowPanel>
                                 <g:FlowPanel ui:field="cpuThreadsPanel" 
addStyleNames="{style.nestedSubsequentPanel}">
                                     <g:Label ui:field="cpuThreadsPanelTitle" 
addStyleNames="{style.panelTitle}" />
-                                    <d:InfoIcon ui:field="cpuThreadsInfo" 
addStyleNames="{style.panelInfo} cpv_panelInfo_pfly_fix" />
+                                    <d:InfoIcon ui:field="cpuThreadsInfo" 
addStyleNames="{style.panelInfo}" />
                                     <ge:EntityModelCheckBoxEditor 
ui:field="countThreadsAsCoresEditor" />
                                 </g:FlowPanel>
                                 <g:FlowPanel 
addStyleNames="{style.nestedSubsequentPanel}">
@@ -245,15 +245,15 @@
                                 </g:ScrollPanel>
                                 <g:FlowPanel>
                                     <g:Label 
ui:field="schedulerOptimizationPanelTitle" addStyleNames="{style.panelTitle}" />
+                                    <d:InfoIcon 
ui:field="schedulerOptimizationInfoIcon" addStyleNames="{style.panelInfo}" />
                                     <g:HorizontalPanel>
                                         <ge:EntityModelRadioButtonEditor 
ui:field="optimizeForUtilizationEditor" 
addStyleNames="{style.radioButtonLabel}" />
                                         <ge:EntityModelRadioButtonEditor 
ui:field="optimizeForSpeedEditor" addStyleNames="{style.radioButtonLabel}" />
-                                        <d:InfoIcon 
ui:field="schedulerOptimizationInfoIcon" addStyleNames="{style.panelInfo} 
cpv_panelInfo_pfly_fix" />
                                     </g:HorizontalPanel>
                                     <g:HorizontalPanel 
ui:field="allowOverbookingPanel">
                                         <ge:EntityModelRadioButtonEditor 
ui:field="guarantyResourcesEditor" addStyleNames="{style.radioButtonLabel}"/>
                                         <ge:EntityModelRadioButtonEditor 
ui:field="allowOverbookingEditor" addStyleNames="{style.radioButtonLabel}"/>
-                                        <d:InfoIcon 
ui:field="allowOverbookingInfoIcon" addStyleNames="{style.panelInfo} 
cpv_panelInfo_pfly_fix" />
+                                        <d:InfoIcon 
ui:field="allowOverbookingInfoIcon" addStyleNames="{style.panelInfo}" />
                                     </g:HorizontalPanel>
                                 </g:FlowPanel>
                                 <g:FlowPanel ui:field="additionPropsPanel" 
addStyleNames="{style.nestedSubsequentPanel}">
diff --git a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 
b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
index 583ff1a..4c4f075 100644
--- a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
+++ b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
@@ -153,10 +153,6 @@
     position: relative;
     left: -9px;
 }
-.cpv_panelInfo_pfly_fix {
-    margin-left: 5px !important;
-
-}
 div.avw_contentWidget_pfly_fix {
     position: relative;
     top: 6px;


-- 
To view, visit http://gerrit.ovirt.org/33371
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61c4120ac6869b27d9faa2a3a0481d768911a5bb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to