Moti Asayag has uploaded a new change for review.
Change subject: engine: Deprecate SetupNetworks command
......................................................................
engine: Deprecate SetupNetworks command
The setup networks command soon be replaced by the
HostSetupNetworks command which will provides more natural
api which is compliant with the vdsm api.
Change-Id: I48ee73f37ad20139abb1735cfadd780cb4a2153b
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
3 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/33330/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
index dae2aaa..a6d8eb1 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
@@ -35,6 +35,10 @@
import org.ovirt.engine.core.utils.transaction.TransactionMethod;
import org.ovirt.engine.core.utils.transaction.TransactionSupport;
+/**
+ * Replaced by {@link
org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand}
+ */
+@Deprecated
@NonTransactiveCommandAttribute
public class SetupNetworksCommand<T extends SetupNetworksParameters> extends
VdsCommand<T> {
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
index c3d8fc9..9fe2cc8 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
@@ -10,7 +10,7 @@
import org.ovirt.engine.core.common.validation.annotation.ConfiguredRange;
import
org.ovirt.engine.core.common.validation.annotation.NoRepetitiveStaticIpInList;
-
+@Deprecated
public class SetupNetworksParameters extends VdsActionParameters {
@Valid
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
index e99a0ee..8940078 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
@@ -97,6 +97,8 @@
RemoveNetwork(155, ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK, false,
QuotaDependency.NONE),
UpdateNetwork(156, ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK, false,
QuotaDependency.NONE),
CommitNetworkChanges(157, ActionGroup.CONFIGURE_HOST_NETWORK,
QuotaDependency.NONE),
+
+ @Deprecated
SetupNetworks(158, ActionGroup.CONFIGURE_HOST_NETWORK,
QuotaDependency.NONE),
PersistentSetupNetworks(159, QuotaDependency.NONE),
--
To view, visit http://gerrit.ovirt.org/33330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48ee73f37ad20139abb1735cfadd780cb4a2153b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
