Ayal Baron has posted comments on this change. Change subject: webadmin: filter storage format versions on new SD ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java Line 636: && (dataCenter.getcompatibility_version().compareTo(Version.v3_1) <= 0)) should just drop this last check Line 665: getFormat().setIsChangable(true); need to verify that type is not ISO/Export here as we do not support it. -- To view, visit http://gerrit.ovirt.org/6629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4986e9aa12a14201adf9ac4d718d33eaaf4b8e7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
