Roy Golan has posted comments on this change. Change subject: engine: don't allow to create VM with balloon on ppc64 ......................................................................
Patch Set 5: (2 comments) Your work here makes it perfectly valid at this point. http://gerrit.ovirt.org/#/c/32243/5/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java: Line 95: } Line 96: Line 97: @Test Line 98: public void refuseBalloonOnPPC() { Line 99: final ImportVmCommand<ImportVmParameters> c = setupDiskSpaceTest(0); same problem as in 3.5 Line 100: c.getParameters().getVm().setBalloonEnabled(true); Line 101: c.getParameters().getVm().setClusterArch(ArchitectureType.ppc64); Line 102: VDSGroup cluster = new VDSGroup(); Line 103: cluster.setArchitecture(ArchitectureType.ppc64); Line 110: } Line 111: Line 112: @Test Line 113: public void acceptBalloon() { Line 114: final ImportVmCommand<ImportVmParameters> c = setupDiskSpaceTest(0); and here Line 115: c.getParameters().getVm().setBalloonEnabled(true); Line 116: c.getParameters().getVm().setClusterArch(ArchitectureType.x86_64); Line 117: VDSGroup cluster = new VDSGroup(); Line 118: cluster.setArchitecture(ArchitectureType.x86_64); -- To view, visit http://gerrit.ovirt.org/32243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
