Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Use common code for remote engine pki ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/33024/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py: Line 137: tries_left > 0 Line 138: ): Line 139: remote_engine_host = self.environment[ Line 140: oreportscons.EngineConfigEnv.ENGINE_FQDN Line 141: ] > Do we need to ask again about the engine fqdn to prevent input errors or sh Of course we do not want to ask again. Why does the above work? because we ask for engine_fqdn in sso, which runs during the network customization, and here we are at pki which is after network. Line 142: Line 143: with contextlib.closing( Line 144: urllib2.urlopen( Line 145: 'http://{engine_fqdn}/ovirt-engine/services/' Line 159: 'Please check access to the engine and its ' Line 160: 'status.' Line 161: ) Line 162: ) Line 163: time.sleep(10) > Probably it's better to use a named constant here. Perhaps, also for tries_left above. Perhaps even make them in env :-) I didn't bother for now. Line 164: tries_left -= 1 Line 165: if self._need_ca_cert and self._apache_ca_cert is None: Line 166: raise RuntimeError(_('Failed to get CA Certificate from engine')) Line 167: -- To view, visit http://gerrit.ovirt.org/33024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7a549d09dc85293beba24327ea44ef1dcaf4a55 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
