Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: keeping NFS ports open in case of preexisting exports ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/32867/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py: Line 126: Line 127: self.environment[ Line 128: oenginecons.SystemEnv.NFS_CONFIG_ENABLED_LEGACY_IN_POSTINSTALL Line 129: ] = False Line 130: missing: self.command.detect in stage setup. I know it's already done in another plugin, but if we remove it from there, here will fail. I think it's better to ensurie that the plugin has all it needs here. Line 131: rc, stdout, stderr = self.execute( Line 132: ( Line 133: self.command.get('exportfs'), Line 134: ), -- To view, visit http://gerrit.ovirt.org/32867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id99ac88af780c6239655676b5290230076d0284b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
