Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: config engine to access reports ......................................................................
Patch Set 6: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/33148/6/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 717: os.path.join( Line 718: oreportscons.FileLocations.OVIRT_ENGINE_REPORTS_JASPER_WAR, Line 719: 'reports.xml', Line 720: ) Line 721: ) I'm ok with this, just wondering if it may be better to use a local file transaction instead of just using copyfile. Line 722: Line 723: @plugin.event( Line 724: stage=plugin.Stages.STAGE_MISC, Line 725: name=oreportscons.Stages.JASPER_DEPLOY_IMPORT, -- To view, visit http://gerrit.ovirt.org/33148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b7ea55fc0c8204a88edf39c055c2bb2d53d6dde Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
