Alon Bar-Lev has posted comments on this change. Change subject: persist.py: use persist from utils when possible ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33090/4/src/plugins/ovirt-host-deploy/node/persist.py File src/plugins/ovirt-host-deploy/node/persist.py: Line 56: _persist = Config().persist Line 57: except ImportError: Line 58: # If it failed, then try importing the legacy code Line 59: from ovirtnode import ovirtfunctions Line 60: _persist = ovirtfunctions.ovirt_store_config but can you please checkout my previous comment? instead of replaying on same signature to use local function or lambda? Line 61: else: Line 62: raise RuntimeError("Cannot persist task!") Line 63: Line 64: for f in ( -- To view, visit http://gerrit.ovirt.org/33090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b24131bbddbcc0df9454cc617620cd9aff09c8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
