Vojtech Szocs has posted comments on this change. Change subject: frontend: add numa support to VM dialog ......................................................................
Patch Set 4: Code-Review+2 Patch looks good, just one small comment that can be addressed later on - in VmModelBehaviorBase you do: // "model" is the dialog's model // setWindow call triggers reveal of NumaSupportPopupPresenterWidget getModel().setWindow(model); but unless I miss something, you should also do: model.setHelpTag(HelpTag.some_help_tag); so that dialog help tags are in sync with source code. This can be done in a follow-up patch, though. -- To view, visit http://gerrit.ovirt.org/33194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05b83028b722088e39ad7156c77ad4eb479dc241 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
