[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Add numa node index when create vm numa node

[gchaplik]

Hello Xiaolei Shi,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/33184

to review the following change.

Change subject: core: Add numa node index when create vm numa node
......................................................................

core: Add numa node index when create vm numa node

Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Bug-Url: https://bugzilla.redhat.com/1099814
Signed-off-by: Bruce Shi <xiao-lei....@hp.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java
M 
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/84/33184/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java
index 5b3021d..dd2f1ab 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java
@@ -21,6 +21,7 @@
             Map<String, Object> createVmNumaNode = new HashMap<>();
             createVmNumaNode.put(VdsProperties.NUMA_NODE_CPU_LIST, 
NumaUtils.buildStringFromListForNuma(node.getCpuIds()));
             createVmNumaNode.put(VdsProperties.VM_NUMA_NODE_MEM, 
String.valueOf(node.getMemTotal()));
+            createVmNumaNode.put(VdsProperties.NUMA_NODE_INDEX, 
node.getIndex());
             createVmNumaNodes.add(createVmNumaNode);
         }
         return createVmNumaNodes;
diff --git 
a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java
 
b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java
index 2cbe249..7ed5b01 100644
--- 
a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java
+++ 
b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java
@@ -35,6 +35,8 @@
         List<Map<String, Object>> vmNumaNodesSetting =
                 NumaSettingFactory.buildVmNumaNodeSetting(vmNumaNodes);
         assertEquals(2, vmNumaNodesSetting.size());
+        
assertTrue(vmNumaNodesSetting.get(0).containsKey(VdsProperties.NUMA_NODE_INDEX));
+        assertEquals(0, 
vmNumaNodesSetting.get(0).get(VdsProperties.NUMA_NODE_INDEX));
         
assertTrue(vmNumaNodesSetting.get(0).containsKey(VdsProperties.NUMA_NODE_CPU_LIST));
         assertEquals("0,1,2,3", 
vmNumaNodesSetting.get(0).get(VdsProperties.NUMA_NODE_CPU_LIST));
         
assertTrue(vmNumaNodesSetting.get(1).containsKey(VdsProperties.VM_NUMA_NODE_MEM));


-- 
To view, visit http://gerrit.ovirt.org/33184
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches