Allon Mureinik has posted comments on this change. Change subject: core: Update AddStorageDomainCommonTest to succeed when storage pool is null ......................................................................
Patch Set 1: Code-Review+2 (1 comment) This patch uncovers a WRONG behavior of the command - giving +2 as to free the build, need to revisit. http://gerrit.ovirt.org/#/c/33173/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java: Line 189 Line 190 Line 191 Line 192 Line 193 This is wrong - if the given ID does not exist the command SHOULD fail. -- To view, visit http://gerrit.ovirt.org/33173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ba3a0f2c7c08c1592a5791784ca5023b61a156f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
