Roy Golan has posted comments on this change. Change subject: engine: NUMA feature transaction support ......................................................................
Patch Set 12: (5 comments) http://gerrit.ovirt.org/#/c/28241/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java: Line 35: Guid dedicatedHost = getParameters().getDedicatedHost(); Line 36: if (dedicatedHost != null) { Line 37: return dedicatedHost; Line 38: } Line 39: return getVm().getDedicatedVmForVds(); pls remove this and use only the getDedicatedHost from the parameters Line 40: } Line 41: Line 42: protected NumaTuneMode getNumaTuneMode() { Line 43: NumaTuneMode numaTuneMode = getParameters().getNumaTuneMode(); Line 43: NumaTuneMode numaTuneMode = getParameters().getNumaTuneMode(); Line 44: if (numaTuneMode != null) { Line 45: return numaTuneMode; Line 46: } Line 47: return getVm().getNumaTuneMode(); same Line 48: } Line 49: Line 50: protected MigrationSupport getMigrationSupport() { Line 51: MigrationSupport migrationSupport = getParameters().getMigrationSupport(); Line 52: if (migrationSupport != null) { Line 53: return migrationSupport; Line 54: } Line 55: return getVm().getMigrationSupport(); Line 56: } same Line 57: Line 58: @Override Line 59: protected boolean canDoAction() { Line 60: List<VmNumaNode> vmNumaNodes = getParameters().getVmNumaNodeList(); http://gerrit.ovirt.org/#/c/28241/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java: Line 31: List<VdsNumaNode> nodes = new ArrayList<>(); Line 32: for (VmNumaNode vmNumaNode : vmNumaNodes) { Line 33: vmNumaNode.setId(Guid.newGuid()); Line 34: for (Pair<Guid, Pair<Boolean, Integer>> pair : vmNumaNode.getVdsNumaNodeList()) { Line 35: int index = pair.getSecond().getSecond(); possible NPE Line 36: // if pinned set pNode Line 37: if (pair.getSecond().getFirst()) { Line 38: for (VdsNumaNode vdsNumaNode : vdsNumaNodes) { Line 39: if (vdsNumaNode.getIndex() == index) { http://gerrit.ovirt.org/#/c/28241/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java: Line 30: List<VdsNumaNode> nodes = new ArrayList<>(); Line 31: for (VmNumaNode vmNumaNode : vmNumaNodes) { Line 32: for (Pair<Guid, Pair<Boolean, Integer>> pair : vmNumaNode.getVdsNumaNodeList()) { Line 33: if (pair.getSecond().getFirst()) { Line 34: int index = pair.getSecond().getSecond(); possible NPE here: index might try to eval Integer.valueOf(null) this needs protection especially in an API code because we don't know what will be sent Line 35: for (VdsNumaNode vdsNumaNode : vdsNumaNodes) { Line 36: if (vdsNumaNode.getIndex() == index) { Line 37: pair.setFirst(vdsNumaNode.getId()); Line 38: break; -- To view, visit http://gerrit.ovirt.org/28241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84e59fa38c9174fe7150116bf3c8832f7fac1dd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
