Tal Nisan has uploaded a new change for review. Change subject: core: Remove storage format validation when adding unattached data domain ......................................................................
core: Remove storage format validation when adding unattached data domain Remove storage format validation when adding an unattached data domain with a host that doesn't have a data center Change-Id: I4feea2d476e89e89d2b1ad572ce64904063a0914 Bug-Url: https://bugzilla.redhat.com/1141784 Signed-off-by: Tal Nisan <tni...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/33166/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java index 7078600..be9b137 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java @@ -199,8 +199,10 @@ StorageFormatType storageFormat = getStorageDomain().getStorageFormat(); StoragePool targetStoragePool = getTargetStoragePool(); + // No reason to check supported storage format if we don't have a pool, the storage format will be validated + // upon the future attachment of the the created domain to a pool if (targetStoragePool == null) { - return false; + return true; } Set<StorageFormatType> supportedStorageFormats = -- To view, visit http://gerrit.ovirt.org/33166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4feea2d476e89e89d2b1ad572ce64904063a0914 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
