Oved Ourfali has posted comments on this change. Change subject: core: allow 2% gap in host low swap ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33164/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 551: logable.addCustomValue("HostName", _vds.getName()); Line 552: logable.addCustomValue("UsedSwap", swapUsedPercent.toString()); Line 553: logable.addCustomValue("AvailableSwapMemory", stat.getswap_free().toString()); Line 554: logable.addCustomValue("Threshold", stat.getswap_free() < allowedMinAvailableThreshold ? Line 555: allowedMinAvailableThreshold.toString() : maxUsedPercentageThreshold.toString()); in the user message you should still show the configured threshold, and not with the 2% decrease. Line 556: auditLog(logable, valueToLog); Line 557: } Line 558: } Line 559: -- To view, visit http://gerrit.ovirt.org/33164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3f5da5398141eeba83549a7e425e9f6b9f8673e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
