Roy Golan has posted comments on this change. Change subject: engine: NUMA feature queries and actions validation ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/27617/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1947: * Defines the parameter name used by numa migration on/off Line 1948: */ Line 1949: @TypeConverterAttribute(Boolean.class) Line 1950: @DefaultValueAttribute("false") Line 1951: NUMAMigration, > naming - should be SupportNUMAMigration like the convention NUMAMigrationSupported Line 1952: Line 1953: @TypeConverterAttribute(List.class) Line 1954: @DefaultValueAttribute("") Line 1955: @OptionBehaviourAttribute(behaviour = OptionBehaviour.CommaSeparatedStringArray) -- To view, visit http://gerrit.ovirt.org/27617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c299405ec5d82ada713ed3d220554bf3055c145 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
