Ofer Schreiber has posted comments on this change.
Change subject: packaging: Modify user interface of engine-setup (#832767)
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File packaging/fedora/setup/engine-setup.py
Line 107: fqdn - recevies the fqdn of the host
better be:
generates org name according to th fqdn
Line 109: fqdn = socket.getfqdn().split('.', 1)
I'm missing a comment here, something like
# Splliting fqdn only once in order to get only the domain name
Line 114: return
you should return ""
Line 1710: controller.MESSAGES.append(output_messages.INFO_RHEVM_URL %
controller.CONF["HTTPS_URL"])
remove blank
--
To view, visit http://gerrit.ovirt.org/6592
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3cb27b4b6dbaaafb19a3d61b7a272e4e1ad91b8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
