Liron Aravot has uploaded a new change for review. Change subject: core: RemoveDiskCommand - added TODO comments ......................................................................
core: RemoveDiskCommand - added TODO comments added the following TODOs: 1. RemoveDiskCommand class - this command handles at least few different cases of disk removal -it should be separated to different classes that will handle different scenarios 2.buildSharedLockMap() method - there might be a race condition here - the list of vm's is loaded and only afterwards a lock is performed - so we can't be aware to changes in DB to the vms list and may perform the operation on an outdated list 3.EndSuccessfully() method - need to verify that this list of vms cannot differ from the one that was processed on the CanDoAction phase. Change-Id: Id852c3488937942877da717863d339a23ab36ae0 Signed-off-by: Liron Aravot <lara...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/6604/1 -- To view, visit http://gerrit.ovirt.org/6604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id852c3488937942877da717863d339a23ab36ae0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
