Omer Frenkel has posted comments on this change. Change subject: core: monitoring - extract saveToDb and afterRefresh of VMs ......................................................................
Patch Set 9: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27918/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 623: getVdsEventListener().handleVdsMaintenanceTimeout(_vds.getId()); Line 624: _vdsManager.calculateNextMaintenanceAttemptTime(); Line 625: } Line 626: Line 627: private void afterVMsRefreshTreatment() { missing a call to this method Line 628: // rerun all vms from rerun list Line 629: for (Guid vm_guid : _vmsToRerun) { Line 630: log.errorFormat("Rerun vm {0}. Called from vds {1}", vm_guid, _vds.getName()); Line 631: ResourceManager.getInstance().RerunFailedCommand(vm_guid, _vds.getId()); -- To view, visit http://gerrit.ovirt.org/27918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94bb7984b4767c434786320d5d08ae4dedf29e4c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
